[executorch] Sync torchao version #4945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4945
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c642963 with merge base a5157de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.torchao-version
branch
2 times, most recently
from
deaae41 to
845c7e1
Compare
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Aug 28, 2024
lucylq
force-pushed
the
lfq.torchao-version
branch
from
845c7e1 to
55f8f3d
Compare
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Sync torchao installs across ExecuTorch install_requirements. torchao is used in: - llama2 - flamingo (via torchtune) - phi3 lora (via torchtune) Currently: - ExecuTorch llama2 installs torchao==0.0.1 - Torchtune installs torchao==0.3.0 - To export flamingo, which contains recent changes in torch and torchtune, we require a recent version, due to torch x torchao bc issue fixed by pytorch/ao#638 This PR adds a torchao commit hash, so that we can use a recent and consistent version of torchao in ExecuTorch. Note that torchao does not have prebuilt macos nightlies, which is why we use a commit hash instead of nightly. Test Plan: Imported from GitHub, without a `Test Plan:` line. ``` ./install_requirements.sh --pybind xnnpack bash examples/models/flamingo/install_requirements.sh python examples/models/flamingo/export_preprocess.py ``` confirm torchao==0.5.0+git0916b5b installed confirm preprocess.pte generated Reviewed By: larryliu0820 Differential Revision: D61925882 Pulled By: lucylq
facebook-github-bot
force-pushed
the
lfq.torchao-version
branch
from
55f8f3d to
c642963
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61925882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync torchao installs across ExecuTorch install_requirements. torchao is used in:
Currently:
This PR adds a torchao commit hash, so that we can use a recent and consistent version of torchao in ExecuTorch.
Note that torchao does not have prebuilt macos nightlies, which is why we use a commit hash instead of nightly.
Test plan:
confirm torchao==0.5.0+git0916b5b installed
confirm preprocess.pte generated