Hide and simplify backend registry internals #4947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4947
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b9119cd with merge base a5157de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61928651 |
Summary: Pull Request resolved: pytorch#4947 All users of the backend registry use the global functions, so we can hide the class. And since there's only one registry instance, we don't need the class. Differential Revision: D61928651
|
This pull request was exported from Phabricator. Differential Revision: D61928651 |
dbort
force-pushed
the
export-D61928651
branch
from
274271a to
b9119cd
Compare
mergennachin
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All users of the backend registry use the global functions, so we can hide the class.
And since there's only one registry instance, we don't need the class.
Differential Revision: D61928651