Update android-perf.yml after #5004 #5016
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5016
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5da07f8 with merge base 0a8547a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| android-app-archive: https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifact/llm_demo_bpe/app-debug.apk | ||
| android-test-archive: https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifact/llm_demo_bpe/app-debug-androidTest.apk | ||
| android-app-archive: https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifact/llm_demo/app-debug.apk | ||
| android-test-archive: https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifact/llm_demo/app-debug-androidTest.apk |
There was a problem hiding this comment.
If the new app doesn't cover llm models, the workflow needs to be updated accordingly. Otherwise you may end up having a non-genai model deployed with llm app, and vice versa
There was a problem hiding this comment.
That can be done later. For now, let's verify if the new app is able to load and run nongenai models (for xnnpack and qnn). The app needs to be built with both xnnpack and qnn which is fine since we are benchmarking the model instead of the app. For running the QNN model the device model/serial may be an issue per #4973, if yes, I think we should at least make sure the app can built with qnn delegate successfully
|
Fixed by #5050 already |
Should update artifact path #5004