Add op: convolution_backward #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: SS-JIA Differential Revision: D62028659
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5032
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 61c2bc2 with merge base ef3c53d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62028659 |
metascroy
approved these changes
Sep 3, 2024
python3kgae
reviewed
Sep 25, 2024
| bool transposed, | ||
| IntArrayRef output_padding, | ||
| int64_t groups, | ||
| exec_aten::ArrayRef<bool> output_mask, |
There was a problem hiding this comment.
Why is the type for output_mask exec_aten::ArrayRef<bool> instead of std::array<bool, 3>?
It doesn't match the declaration of convolution_backward_out in \executorch\pip-out\temp.win-amd64-cpython-311\cmake-out\kernels\portable\portable_ops_lib\NativeFunctions.h which has type std::array<bool, 3> for output_mask.
This mismatch will cause link error on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed By: SS-JIA
Differential Revision: D62028659