Remove expensive print from lowered_backend_module.py #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5046
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (28 Unrelated Failures)As of commit 953de11 with merge base e3cbeed ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62155526 |
tarun292
approved these changes
Sep 3, 2024
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: pytorch#5046 This one print was taking over 900 seconds (15 minutes) in `to_backend`. This was in a resnet152 test we were trying. This print is not important to keep around and not worth the extra compile time, remove it. Reviewed By: tarun292 Differential Revision: D62155526
dulinriley
force-pushed
the
export-D62155526
branch
from
d575bb9 to
40d89ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62155526 |
Summary: Pull Request resolved: pytorch#5046 This one print was taking over 900 seconds (15 minutes) in `to_backend`. This was in a resnet152 test we were trying. This print is not important to keep around and not worth the extra compile time, remove it. Reviewed By: tarun292 Differential Revision: D62155526
|
This pull request was exported from Phabricator. Differential Revision: D62155526 |
dulinriley
force-pushed
the
export-D62155526
branch
from
40d89ac to
953de11
Compare
|
Wow, great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This one print was taking over 900 seconds (15 minutes) in
to_backend.This was in a resnet152 test we were trying.
Move this to logging.debug which won't materialize the string by default.
I can also consider just removing this print if nobody needs it, a debugger
might be a better way to access this info.
I can also consider just deleting this instead if people don't need it.
Differential Revision: D62155526