[tokenizer] Consolidate how runner decide which tokenizer to use #5052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Make sure `tiktoken.cpp` gives correct error when file is invalid. Make sure `runner.cpp` is able to fallback to BPETokenizer when an invalid tokenizer.model file is given. Test Plan: Rely on unittest Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5052
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fefc958 with merge base f824c1e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
swolchok
approved these changes
Sep 4, 2024
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make sure
tiktoken.cppgives correct error when file is invalid. Make surerunner.cppis able to fallback to BPETokenizer when an invalid tokenizer.model file is given.Test Plan: Rely on unittest
Reviewers:
Subscribers:
Tasks:
Tags: