Remove usages of extract_constant_segment=True #5082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove usages before deprecation. default `serialize_pte_binary` to set `extract_constant_segment` to true, which is the default set in the config. Now that we're removing usages, we no longer explicitly set it to true. Note that the `extract_constant_segment` argument will be removed in the next diff in the stack. Reviewed By: dbort Differential Revision: D61995885
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5082
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cf49373 with merge base ae05ed8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61995885 |
JacobSzwejbka
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove usages before deprecation.
default
serialize_pte_binaryto setextract_constant_segmentto true, which is the default set in the config. Now that we're removing usages, we no longer explicitly set it to true.Note that the
extract_constant_segmentargument will be removed in the next diff in the stack.Reviewed By: dbort
Differential Revision: D61995885