[ExecuTorch] Make ForcedUnroll usage in bf16 BlasKernel actually work for -Oz builds #5195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5195
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit b7074dc with merge base 2b50c76 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
This was referenced Sep 9, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
kimishpatel
approved these changes
Sep 10, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62154247 |
swolchok
changed the base branch from
gh/swolchok/47/base
to
gh/swolchok/46/head
kirklandsign
force-pushed
the
gh/swolchok/46/head
branch
from
faa5ccd to
2ca03f5
Compare
kirklandsign
force-pushed
the
gh/swolchok/47/head
branch
from
71819a6 to
a25a8b0
Compare
kirklandsign
force-pushed
the
gh/swolchok/46/head
branch
from
2ca03f5 to
7088078
Compare
… for -Oz builds Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/) [ghstack-poisoned]
kirklandsign
force-pushed
the
gh/swolchok/47/head
branch
from
a25a8b0 to
b7074dc
Compare
|
this stack needs re-export |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
… for -Oz builds Pull Request resolved: pytorch/executorch#5195 Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda. ghstack-source-id: 241805195 @exported-using-ghexport Differential Revision: [D62154247](https://our.internmc.facebook.com/intern/diff/D62154247/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Clang is very resistant to inlining under -Oz. For ForcedUnroll to actually unroll, we need to force-inline the lambda.
Differential Revision: D62154247