Add definition to etrecord_path to the devtools tutorial
#5481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #5458 This diff adds the definition for variable `etrecord_path`. `etrecord_path` was defined in previous steps in the tutorial, but when user gets to this step, they would usually start a new script, so we should define this variable again. Reviewed By: Gasoonjia, dvorjackz Differential Revision: D62921869 fbshipit-source-id: 1d274d5fc76f84f6f943295c142141051fd85cb4 (cherry picked from commit b89c52c)
This was referenced Sep 19, 2024
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5481
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit acc7466 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jackzhxng
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds the definition for variable
etrecord_path.etrecord_pathwas defined in previous steps in the tutorial, but when user gets to this step, they would usually start a new script, so we should define this variable again.Differential Revision: D62921869