Remove torch:: namespace reference from LLaMMARunner.mm
#5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5516
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d89b5c1 with merge base b5741a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
examples/ code should use the new `executorch::` namespaces. Test Plan: Built the app using the instructions at https://github.com/pytorch/executorch/blob/main/examples/demo-apps/apple_ios/LLaMA/README.md
dbort
force-pushed
the
dbort-examples-ios
branch
from
5e855e1 to
d89b5c1
Compare
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Sep 23, 2024
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: examples/ code should use the new `executorch::` namespaces. Pull Request resolved: #5516 Test Plan: Built the app using the instructions at https://github.com/pytorch/executorch/blob/main/examples/demo-apps/apple_ios/LLaMA/README.md Reviewed By: larryliu0820 Differential Revision: D63138639 Pulled By: dbort fbshipit-source-id: fffb6d35d425dd733eead1b24ee8b9f2831e65c0 (cherry picked from commit b361f91)
Cherry picking #5516The cherry pick PR is at #5557 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 24, 2024
Remove `torch::` namespace reference from LLaMMARunner.mm (#5516) Summary: examples/ code should use the new `executorch::` namespaces. Pull Request resolved: #5516 Test Plan: Built the app using the instructions at https://github.com/pytorch/executorch/blob/main/examples/demo-apps/apple_ios/LLaMA/README.md Reviewed By: larryliu0820 Differential Revision: D63138639 Pulled By: dbort fbshipit-source-id: fffb6d35d425dd733eead1b24ee8b9f2831e65c0 (cherry picked from commit b361f91) Co-authored-by: Dave Bort <dbort@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/ code should use the new
executorch::namespaces.Test Plan:
Built the app using the instructions at https://github.com/pytorch/executorch/blob/main/examples/demo-apps/apple_ios/LLaMA/README.md