Fix duplicating latest prompt #5546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5546
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 793aaeb with merge base 0ec003b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62761977 |
kirklandsign
approved these changes
Sep 23, 2024
Summary: Pull Request resolved: #5546 The last prompt sent would be included in `getConversationHistory()` + adding it prior to sending it with the generate(). It looks like this got move during the rebasing. To fix this we now call `getConversationHistory()` prior to adding the rawPrompt to a Message. In regards to model response, I noticed that it did not really change the quality of the response. (tested with Llama 3.1) Reviewed By: Riandy Differential Revision: D62761977
|
This pull request was exported from Phabricator. Differential Revision: D62761977 |
cmodi-meta
force-pushed
the
export-D62761977
branch
from
9faf2be to
793aaeb
Compare
|
This pull request has been merged in 3b63839. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: Pull Request resolved: #5546 The last prompt sent would be included in `getConversationHistory()` + adding it prior to sending it with the generate(). It looks like this got move during the rebasing. To fix this we now call `getConversationHistory()` prior to adding the rawPrompt to a Message. In regards to model response, I noticed that it did not really change the quality of the response. (tested with Llama 3.1) Reviewed By: Riandy Differential Revision: D62761977 fbshipit-source-id: 2f975983965fe837147f1ffb8b5dcfa8f2061895 (cherry picked from commit 3b63839)
Cherry picking #5546The cherry pick PR is at #5568 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fix duplicating latest prompt (#5546) Summary: Pull Request resolved: #5546 The last prompt sent would be included in `getConversationHistory()` + adding it prior to sending it with the generate(). It looks like this got move during the rebasing. To fix this we now call `getConversationHistory()` prior to adding the rawPrompt to a Message. In regards to model response, I noticed that it did not really change the quality of the response. (tested with Llama 3.1) Reviewed By: Riandy Differential Revision: D62761977 fbshipit-source-id: 2f975983965fe837147f1ffb8b5dcfa8f2061895 (cherry picked from commit 3b63839) Co-authored-by: Chirag Modi <cmodi@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The last prompt sent would be included in
getConversationHistory()+ adding it prior to sending it with the generate(). It looks like this got move during the rebasing.To fix this we now call
getConversationHistory()prior to adding the rawPrompt to a Message.In regards to model response, I noticed that it did not really change the quality of the response. (tested with Llama 3.1)
Reviewed By: Riandy
Differential Revision: D62761977