Skip to content

[llava] Add tiktoken dep #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[llava] Add tiktoken dep #5586

wants to merge 1 commit into from

Conversation

jackzhxng
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5586

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 110a6a6 with merge base 7de3f81 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024
@jackzhxng jackzhxng changed the title [llava] Add sentencepiece dep [llava] Add tiktoken dep Sep 24, 2024
@jackzhxng jackzhxng marked this pull request as ready for review September 24, 2024 17:31
@facebook-github-bot
Copy link
Contributor

@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dvorjackz merged this pull request in 72245c3.

@kirklandsign kirklandsign deleted the jz/llava-deps branch September 24, 2024 19:42
@jackzhxng
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Sep 24, 2024
@jackzhxng @pytorchbot
Add tiktoken dep (#5586)
8cee48e 
Summary: Pull Request resolved: #5586

Reviewed By: larryliu0820

Differential Revision: D63331756

Pulled By: dvorjackz

fbshipit-source-id: b17d1cafabd7dfd1902a5fe1b6fb02ae06f2b847
(cherry picked from commit 72245c3)
@pytorchbot
Copy link
Collaborator

Cherry picking #5586

The cherry pick PR is at #5608 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 24, 2024
Closed
jackzhxng added a commit that referenced this pull request Sep 24, 2024
@pytorchbot @jackzhxng
[llava] Add tiktoken dep (#5608)
7f8ea44 
Add tiktoken dep (#5586)

Summary: Pull Request resolved: #5586

Reviewed By: larryliu0820

Differential Revision: D63331756

Pulled By: dvorjackz

fbshipit-source-id: b17d1cafabd7dfd1902a5fe1b6fb02ae06f2b847
(cherry picked from commit 72245c3)

Co-authored-by: Jack Zhang <dvorjackz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackzhxng @facebook-github-bot @pytorchbot @larryliu0820