Don't automatically backup settings in Android demo apps #5822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-installing the android demo apps, the OS caches and re-populates values in the settings pane.
I think this might cause some confusion for people trying out the demos but who aren't experienced native app devs (like me 🙂).
specifically for me, the settings caching made me think that old files that i had pushed, removed, and then replaced with other files were still on the device somehow. eg, i replaced a
tokenizer.bin
with atokenizer.model
, and the settings still saidtokenizer.bin
... this made me think maybe the old tokenizer was still floating around in app storage or something.to change the behavior is 1 loc for each demo app. in
examples/demo-apps/android/*Demo/app/src/main/AndroidManifest.xml
,i made a PR for personal glory but no worries if you want to do something else.