Skip to content

Conversation

grisaitis
Copy link
Contributor

When re-installing the android demo apps, the OS caches and re-populates values in the settings pane.

I think this might cause some confusion for people trying out the demos but who aren't experienced native app devs (like me 🙂).

specifically for me, the settings caching made me think that old files that i had pushed, removed, and then replaced with other files were still on the device somehow. eg, i replaced a tokenizer.bin with a tokenizer.model, and the settings still said tokenizer.bin... this made me think maybe the old tokenizer was still floating around in app storage or something.

to change the behavior is 1 loc for each demo app. in examples/demo-apps/android/*Demo/app/src/main/AndroidManifest.xml,

-        android:allowBackup="true"
+        android:allowBackup="false"

i made a PR for personal glory but no worries if you want to do something else.

Copy link

pytorch-bot bot commented Oct 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5822

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 552cbbe with merge base 152e22d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in dae765e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants