Fix get_control_flow_submodules_list call in debug handle generator pass #6187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6187
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea8134a with merge base aa852cc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64309046 |
Olivia-liu
approved these changes
Oct 14, 2024
Summary: We should be using `current_graph_module` not `ep.graph_module` in this loop, otherwise it can go into an infinite loop. Reviewed By: Olivia-liu, bingcy Differential Revision: D64309046
facebook-github-bot
force-pushed
the
export-D64309046
branch
from
33a8397 to
ea8134a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64309046 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ass (#6187) Summary: We should be using `current_graph_module` not `ep.graph_module` in this loop, otherwise it can go into an infinite loop. Reviewed By: Olivia-liu, bingcy Differential Revision: D64309046
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ass (#6187) Summary: We should be using `current_graph_module` not `ep.graph_module` in this loop, otherwise it can go into an infinite loop. Reviewed By: Olivia-liu, bingcy Differential Revision: D64309046
|
This pull request has been merged in 8dbd14c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We should be using
current_graph_modulenotep.graph_modulein this loop, otherwise it can go into a infinite loop.Differential Revision: D64309046