Disable XNNPACK workspace sharing by default #6199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Disable workspace sharing by default. There is currently a crash that occurs when workspace sharing is enabled when freeing the delegate. This change will increase ET memory usage, but needs to be done until we address the root cause. After we are confident that it is fixed, we will revert this change. Differential Revision: D64352037
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6199
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 868c2ed with merge base aa852cc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64352037 |
kirklandsign
approved these changes
Oct 14, 2024
|
This pull request has been merged in ce767cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Disable workspace sharing by default. There is currently a crash that occurs when workspace sharing is enabled when freeing the delegate. This change will increase ET memory usage, but needs to be done until we address the root cause. After we are confident that it is fixed, we will revert this change.
Differential Revision: D64352037