Populates EXECUTORCH_LIBRARIES and other variables in executorch-config.cmake #6204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executorch-config.cmake Summary: As titled. This PR aligns the behavior of `executorch-config.cmake` (being used by building ET from source) and the behavior of `executorch-wheel-config.cmake` (being used by installing ET from pip), by exposing these variables: * `EXECUTORCH_FOUND` set to `ON` when required libraries are found * `EXECUTORCH_LIBRARIES` a list of targets for installed ET libraries * `EXECUTORCH_INCLUDE_DIRS` a list of directory paths to headers Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6204
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 42c8ef0 with merge base aa852cc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
changed the title
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
metascroy
approved these changes
Oct 14, 2024
|
@larryliu0820 merged this pull request in 9bd7f46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executorch-config.cmake
Summary: As titled. This PR aligns the behavior of
executorch-config.cmake(being used by building ET from source) and the behavior ofexecutorch-wheel-config.cmake(being used by installing ET from pip), by exposing these variables:EXECUTORCH_FOUNDset toONwhen required libraries are foundEXECUTORCH_LIBRARIESa list of targets for installed ET librariesEXECUTORCH_INCLUDE_DIRSa list of directory paths to headersTest Plan:
Reviewers:
Subscribers:
Tasks:
Tags: