Skip to content

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  • Previously, we use the term arch_table and soc model interchangeably. However, these 2 terms referd to 2 different things. arch_table is now referred to htp arch table, which refers to htp architecture verison, such as v73, v75, etc. On the other hand, SoC model will be referring to the SoC chipsets ID, such as SM8550, SM8650, etc.
  • Removed tutorial to add SoC. I don't think external users will be able to get SoC IDs.

Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6227

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4f9171c with merge base 1f2b9aa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@winskuo-quic
Copy link
Collaborator Author

winskuo-quic commented Oct 15, 2024

Hi @cccclai,

I think we previously used some of the SoC terms interchangeably, while they actually have different meanings. This PR is to differentiate htp arch and SoC ID. I also removed tutorial to add SoC ID because I think external users does not have access to SoC IDs.
Please have a look.
Thanks

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 55ed63f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants