[Executorch][llama] Rename update_quantized_cache to update_cache #6914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is just really an inplace update op. Nothing special Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6914
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 532c483 with merge base c726a9b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Oct 3, 2024
|
This pull request was exported from Phabricator. Differential Revision: D66041160 |
kimishpatel
added a commit
that referenced
this pull request
Nov 16, 2024
Because it is just really an inplace update op. Nothing special Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) ghstack-source-id: 253887458 Pull Request resolved: #6914
jackzhxng
approved these changes
Nov 16, 2024
This was referenced Nov 20, 2024
…e_cache" Because it is just really an inplace update op. Nothing special Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66041160 |
…e_cache" Because it is just really an inplace update op. Nothing special Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66041160 |
This was referenced Nov 22, 2024
…e_cache" Because it is just really an inplace update op. Nothing special Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66041160 |
facebook-github-bot
merged commit 3af390b
into
gh/kimishpatel/143/base
41 of 43 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 3, 2024
Pull Request resolved: #6914 Because it is just really an inplace update op. Nothing special ghstack-source-id: 255730819 @exported-using-ghexport Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/)
kirklandsign
pushed a commit
that referenced
this pull request
Dec 3, 2024
Pull Request resolved: #6914 Because it is just really an inplace update op. Nothing special ghstack-source-id: 255730819 @exported-using-ghexport Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/) Co-authored-by: Kimish Patel <kimishpatel@fb.com>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#6914 Because it is just really an inplace update op. Nothing special ghstack-source-id: 254987265 @exported-using-ghexport Differential Revision: [D66041160](https://our.internmc.facebook.com/intern/diff/D66041160/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Because it is just really an inplace update op. Nothing special
Differential Revision: D66041160