use-pt-pinned-commit for test-arm-{backend,reference}-delegation #7579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7579
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit a32563d with merge base 98697f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jan 9, 2025
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
swolchok
added
the
release notes: build
digantdesai
approved these changes
Jan 10, 2025
|
looks like I missed a spot of include path fixing in #7040? not sure exactly why this would make it show up though. https://github.com/pytorch/executorch/actions/runs/12700684319/job/35403838935#step:14:13497 |
yep, turns out I needed to add ciflow/trunk on #7040. will fix there. |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
zingo
added
the
partner: arm
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
huydhn
approved these changes
Jan 10, 2025
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
freddan80
approved these changes
Jan 15, 2025
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
swolchok
added a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7579 Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. ghstack-source-id: 263532775 @exported-using-ghexport Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
…gation" Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7579 Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. ghstack-source-id: 263542481 @exported-using-ghexport Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
|
This pull request was exported from Phabricator. Differential Revision: D67996459 |
facebook-github-bot
merged commit 0f96804
into
gh/swolchok/127/base
69 of 70 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
manuelcandales
pushed a commit
that referenced
this pull request
Jan 29, 2025
Pull Request resolved: #7579 Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. ghstack-source-id: 263542481 @exported-using-ghexport Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) Co-authored-by: Scott Wolchok <swolchok@meta.com>
kirklandsign
pushed a commit
that referenced
this pull request
Jan 31, 2025
* --use-pt-pinned-commit in one-off linux jobs Pull Request resolved: #7922 This is needed to respect the torchgen pinned commit for #7546. ghstack-source-id: 263542478 @exported-using-ghexport Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/) * use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023) Pull Request resolved: #7579 Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. ghstack-source-id: 263542481 @exported-using-ghexport Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) Co-authored-by: Scott Wolchok <swolchok@meta.com> --------- Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
Differential Revision: D67996459