[ET-VK] fix index error bug in ViewCopyToSqueezeUnsqueezePass #8281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See T214560872 #8226 added the pass to the partition preprocess pass list, so now it runs on all exports. This uncovered a bug in the squeeze dims finding function in the mobilenet test case. Differential Revision: [D69254910](https://our.internmc.facebook.com/intern/diff/D69254910/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8281
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a939888 with merge base 6fb6332 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
nathanaelsee
pushed a commit
that referenced
this pull request
Feb 6, 2025
See T214560872 #8226 added the pass to the partition preprocess pass list, so now it runs on all exports. This uncovered a bug in the squeeze dims finding function in the mobilenet test case. Differential Revision: [D69254910](https://our.internmc.facebook.com/intern/diff/D69254910/) ghstack-source-id: 265078517 Pull Request resolved: #8281
|
This pull request was exported from Phabricator. Differential Revision: D69254910 |
nathanaelsee
added
bug
release notes: vulkan
junpi3
approved these changes
Feb 7, 2025
…ass" See T214560872 #8226 added the pass to the partition preprocess pass list, so now it runs on all exports. This uncovered a bug in the squeeze dims finding function in the mobilenet test case. Differential Revision: [D69254910](https://our.internmc.facebook.com/intern/diff/D69254910/) [ghstack-poisoned]
nathanaelsee
pushed a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #8281 See T214560872 #8226 added the pass to the partition preprocess pass list, so now it runs on all exports. This uncovered a bug in the squeeze dims finding function in the mobilenet test case. ghstack-source-id: 265183421 @exported-using-ghexport Differential Revision: [D69254910](https://our.internmc.facebook.com/intern/diff/D69254910/)
|
This pull request was exported from Phabricator. Differential Revision: D69254910 |
facebook-github-bot
merged commit e6fe049
into
gh/nathanaelsee/4/base
46 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
nathanaelsee
added a commit
to nathanaelsee/executorch
that referenced
this pull request
Feb 11, 2025
Summary: Reland of D69254910 (pytorch#8281) Backed out in D69286390 (OSS->fbsource diff train) Differential Revision: D69477266
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See T214560872
#8226 added the pass to the partition preprocess pass list, so now it runs on all exports.
This uncovered a bug in the squeeze dims finding function in the mobilenet test case.
Differential Revision: D69254910