Add et_dump related API to module #9284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9284
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit bcc2355 with merge base 67b6009 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
This PR needs a
|
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 7, 2025
Summary: It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Differential Revision: D71135352
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 7, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Differential Revision: D71135352
shoumikhin
reviewed
Jun 7, 2025
extension/module/module.h
Outdated
| @@ -489,6 +499,8 @@ class Module { | |||
| std::unique_ptr<runtime::EventTracer> event_tracer_; | |||
| std::unique_ptr<runtime::DataLoader> data_map_loader_; | |||
| std::unique_ptr<NamedDataMap> data_map_; | |||
| std::unique_ptr<uint8_t[]> debug_buffer_; | |||
There was a problem hiding this comment.
Is this essentially a std::vector?
|
Does the PR name match the changes? |
Ah no it doesn't. I rename the diff, but the PR's name doesn't change... |
cccclai
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
force-pushed
the
export-D71135352
branch
from
afbb4c0 to
3bee831
Compare
cccclai
requested review from
JacobSzwejbka,
larryliu0820 and
Gasoonjia
as code owners
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Differential Revision: D71135352
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Differential Revision: D71135352
cccclai
force-pushed
the
export-D71135352
branch
from
3bee831 to
b9aede0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
force-pushed
the
export-D71135352
branch
from
b9aede0 to
b181cd1
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Differential Revision: D71135352
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Reviewed By: shoumikhin Differential Revision: D71135352
cccclai
force-pushed
the
export-D71135352
branch
from
b181cd1 to
5bc4a17
Compare
shoumikhin
approved these changes
Jun 12, 2025
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Reviewed By: shoumikhin Differential Revision: D71135352
cccclai
force-pushed
the
export-D71135352
branch
from
5bc4a17 to
4328895
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
force-pushed
the
export-D71135352
branch
from
4328895 to
7bfb28e
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Reviewed By: shoumikhin Differential Revision: D71135352
Summary: Pull Request resolved: pytorch#9284 It is for reusing the exention/module in the module definition in pybindings https://github.com/pytorch/executorch/blob/1a918c779e16c0ee903a08b30c1c666d1efb2c57/extension/pybindings/pybindings.cpp#L172 Reviewed By: shoumikhin Differential Revision: D71135352
|
This pull request was exported from Phabricator. Differential Revision: D71135352 |
cccclai
force-pushed
the
export-D71135352
branch
from
7bfb28e to
bcc2355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It is for reusing the exention/module in the module definition in pybindings
executorch/extension/pybindings/pybindings.cpp
Line 172 in 1a918c7
Differential Revision: D71135352