Skip to content

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Mar 14, 2025

Don't build these bundled apps (benchmark and llm demo) from build_android_library.sh. That's for library build only. We can make release artifact about 10 minutes faster. We also have better local build experience.

Also fix the CI

Copy link

pytorch-bot bot commented Mar 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9286

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit da206dd with merge base bb3b623 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2025
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results March 14, 2025 19:55 — with GitHub Actions Inactive
@kirklandsign kirklandsign marked this pull request as ready for review March 14, 2025 21:01
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results March 14, 2025 21:38 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results March 14, 2025 23:13 — with GitHub Actions Inactive
@facebook-github-bot facebook-github-bot merged commit 8c03d04 into main Mar 14, 2025
89 of 90 checks passed
@facebook-github-bot facebook-github-bot deleted the android-skip-demo-app-4 branch March 14, 2025 23:52
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Differential Revision: D71221925

Pull Request resolved: pytorch#9286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants