Skip to content

Conversation

Juanfi8
Copy link
Contributor

@Juanfi8 Juanfi8 commented Mar 17, 2025

Added logic to pass the model_input flag to the aot_arm_compiler

Fixes #9226 .

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Added logic to pass the model_input flag to the aot_arm_compiler
@Juanfi8 Juanfi8 requested a review from digantdesai as a code owner March 17, 2025 13:17
@facebook-github-bot
Copy link
Contributor

Hi @Juanfi8!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

pytorch-bot bot commented Mar 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9310

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit db20be7 with merge base 82f3381 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing ciflow/trunk labels Mar 17, 2025
Copy link

pytorch-bot bot commented Mar 17, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo
Copy link
Collaborator

zingo commented Mar 17, 2025

Great work thanks! Also thanks for adding more into to the help texts.

@zingo
Copy link
Collaborator

zingo commented Mar 17, 2025

Failed tests are unrelated to Arm backend and fail in other jobs

@zingo zingo merged commit 3eb4627 into pytorch:main Mar 17, 2025
78 of 85 checks passed
@Juanfi8 Juanfi8 deleted the add-logic-input-arm-run branch March 24, 2025 10:35
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Added logic to pass the model_input flag to the aot_arm_compiler

Fixes pytorch#9226 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM backend: --model_input flag in run.sh is not passed to the aot_arm_compiler
3 participants