[build Folder Migration] Move build/Codegen.cmake (again) #9314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9314
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 PendingAs of commit 62281c1 with merge base 1011fdc ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
requested review from
GregoryComer,
JacobSzwejbka,
cccclai,
digantdesai,
iseeyuan,
jackzhxng,
larryliu0820,
lucylq,
manuelcandales,
mergennachin,
shoumikhin,
swolchok and
tarun292
as code owners
This PR needs a
|
jathu
added
module: build/install
swolchok
approved these changes
Mar 17, 2025
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
### Summary I know I moved this into `scripts/build` in pytorch#9185, but I think `tools/cmake` makes more sense. This will fit perfectly with `tools/buck` (D71267118), etc. ### Test plan CI cc @larryliu0820 @lucylq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I know I moved this into
scripts/buildin #9185, but I thinktools/cmakemakes more sense. This will fit perfectly withtools/buck(D71267118), etc.Test plan
CI
cc @larryliu0820 @lucylq