Skip to content

Fix lint violation from #9073 #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fix lint violation from #9073 #9496

merged 1 commit into from
Mar 21, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Mar 21, 2025

Summary

Main is failing lint tests introduced in #9073.

Test plan

$ lintrunner -a

@jathu jathu requested a review from larryliu0820 March 21, 2025 17:29
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9496

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Pending

As of commit ea100e7 with merge base e22b21a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@jathu jathu marked this pull request as ready for review March 21, 2025 17:30
@jathu jathu requested a review from cccclai as a code owner March 21, 2025 17:30
@jathu jathu requested review from GregoryComer and swolchok March 21, 2025 17:38
@jathu jathu merged commit 922a508 into main Mar 21, 2025
77 of 82 checks passed
@jathu jathu deleted the jathu/mar-21-fix-lint branch March 21, 2025 18:40
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
@jathu @DannyYuyang-quic
Fix lint violation from pytorch#9073 (pytorch#9496)
f726738 
### Summary
Main is failing lint tests introduced in
pytorch#9073.


### Test plan

```
$ lintrunner -a
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jathu @GregoryComer @facebook-github-bot