Skip to content

Conversation

bsoyluoglu
Copy link
Contributor

@bsoyluoglu bsoyluoglu commented Mar 21, 2025

Summary:
This diff does two things,

1st, expose ET error as they are directly to NSErrors
2nd, deletes the unhandled exception logic as we have 0 unhandled exceptions thrown from the code so we don't need this on the bridging API.

Reviewed By: shoumikhin

Differential Revision:
D71585874

Privacy Context Container: L1322389

cc @shoumikhin @cbilgin

Summary:
This diff does two things,

1st, expose ET error as they are directly to NSErrors
2nd, deletes the unhandled exception logic as we have 0 unhandled exceptions thrown from the code so we don't need this on the bridging API.

Reviewed By: shoumikhin

Differential Revision:
D71585874

Privacy Context Container: L1322389
@bsoyluoglu bsoyluoglu requested a review from shoumikhin as a code owner March 21, 2025 17:32
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9497

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 5 Pending

As of commit 448de76 with merge base 6b573af (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71585874

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin shoumikhin added the module: ios Issues related to iOS code, build, and execution label Mar 21, 2025
@facebook-github-bot facebook-github-bot merged commit 2c3fd71 into pytorch:main Mar 21, 2025
85 of 91 checks passed
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Differential Revision: D71585874

Pull Request resolved: pytorch#9497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: ios Issues related to iOS code, build, and execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants