Skip to content

[BE][ET-VK] update permute to use layout gen #9588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

[BE][ET-VK] update permute to use layout gen #9588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab1237c
[BE][ET-VK] update permute to use layout gen
Mar 25, 2025
e60907a
Update on "[BE][ET-VK] update permute to use layout gen"
Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backends/vulkan/runtime/graph/ops/glsl/permute.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ layout(std430) buffer;

#include "indexing_utils.h"

layout(set = 0, binding = 0, ${IMAGE_FORMAT[DTYPE]}) uniform PRECISION restrict writeonly ${IMAGE_T[NDIM][DTYPE]} image_out;
layout(set = 0, binding = 1) uniform PRECISION ${SAMPLER_T[NDIM][DTYPE]} image_in;
${layout_declare_tensor(B, "w", "t_out", DTYPE, STORAGE)}
${layout_declare_tensor(B, "r", "t_in", DTYPE, STORAGE)}

layout(push_constant) uniform PRECISION restrict Block {
ivec4 out_limits;
Expand Down Expand Up @@ -72,7 +72,7 @@ void main() {
fetch_pos[packed_dim] >>= 2;

// fetch input texel
VEC4_T inval = VEC4_T(texelFetch(image_in, fetch_pos, 0));
VEC4_T inval = VEC4_T(load_texel(t_in, fetch_pos));
outval[j] = inval[in_packed_dim_lane_index];

// go to next position in the input, that is mapped to the packed dim in the output
Expand All @@ -81,5 +81,5 @@ void main() {

pos[packed_dim] = int(gl_GlobalInvocationID[packed_dim]);

imageStore(image_out, pos, outval);
imageStore(t_out, pos, outval);
}
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/permute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ permute:
parameter_names_with_default_values:
DTYPE: float
NDIM: 3
STORAGE: texture3d
generate_variant_forall:
DTYPE:
- VALUE: half
Expand Down
Loading