Skip to content

[ET-VK][ez] Fix printing shader IRs #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

[ET-VK][ez] Fix printing shader IRs #9648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a7a11
[ET-VK][ez] Fix printing shader IRs
SS-JIA Mar 26, 2025
3dfe673
Update on "[ET-VK][ez] Fix printing shader IRs"
SS-JIA Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions backends/vulkan/runtime/api/Context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ Context* context() {

VkPipeline Context::get_shader_pipeline(
const vkapi::ShaderInfo& shader,
const vkapi::SpecVarList& spec_constants) {
const vkapi::SpecVarList& additional_constants) {
const uint32_t push_constants_size = 128u;

VkDescriptorSetLayout shader_layout =
Expand All @@ -281,12 +281,15 @@ VkPipeline Context::get_shader_pipeline(
pipeline_layout_cache().retrieve(shader_layout, push_constants_size);

const utils::WorkgroupSize local_workgroup_size(4u, 4u, 1u);
vkapi::SpecVarList spec_constants = {
SV(local_workgroup_size[0u]),
SV(local_workgroup_size[1u]),
SV(local_workgroup_size[2u])};

spec_constants.append(additional_constants);

VkPipeline pipeline = pipeline_cache().retrieve(
{pipeline_layout,
shader_cache().retrieve(shader),
spec_constants,
local_workgroup_size});
{pipeline_layout, shader_cache().retrieve(shader), spec_constants});

return pipeline;
}
Expand Down
Loading