Skip to content

[BE][ET-VK] update max_pool2d to use layout gen #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[BE][ET-VK] update max_pool2d to use layout gen #9657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions backends/vulkan/runtime/graph/ops/glsl/max_pool2d.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,12 @@

layout(std430) buffer;

layout(set = 0, binding = 0, ${IMAGE_FORMAT[DTYPE]}) uniform PRECISION restrict writeonly ${IMAGE_T[NDIM][DTYPE]} image_out;
layout(set = 0, binding = 1, ${IMAGE_FORMAT["int"]}) uniform PRECISION restrict writeonly ${IMAGE_T[NDIM]["int"]} image_idx;
layout(set = 0, binding = 2) uniform PRECISION sampler3D image_in;

layout(set = 0, binding = 3) uniform PRECISION restrict OutLimits {
ivec3 out_limits;
};

layout(set = 0, binding = 4) uniform PRECISION restrict InSizes {
ivec4 in_sizes;
};

layout(set = 0, binding = 5) uniform PRECISION restrict Params {
ivec2 kernel_size;
ivec2 stride;
ivec2 padding;
ivec2 dilation;
};
${layout_declare_tensor(B, "w", "t_out", DTYPE, STORAGE)}
${layout_declare_tensor(B, "w", "t_idx", "int", STORAGE)}
${layout_declare_tensor(B, "r", "t_in", DTYPE, STORAGE)}
${layout_declare_ubo(B, "ivec3", "out_limits")}
${layout_declare_ubo(B, "ivec4", "in_sizes")}
${layout_declare_ubo(B, "ivec2", "kernel_size", "ivec2", "stride", "ivec2", "padding", "ivec2", "dilation")}

layout(local_size_x_id = 0, local_size_y_id = 1, local_size_z_id = 2) in;

Expand All @@ -54,7 +42,7 @@ void main() {
for (int y = start.y; y < end.y; y += dilation.y) {
for (int x = start.x; x < end.x; x += dilation.x) {
if ((x >= 0 && x < in_sizes.x) && (y >= 0 && y < in_sizes.y)) {
const vec4 cur_texel = texelFetch(image_in, ivec3(x, y, pos.z), 0);
const vec4 cur_texel = load_texel(t_in, ivec3(x, y, pos.z));

// Set idx if value is greatest in the pool; else, keep the existing idx.
ivec4 cur_idx = ivec4(x + int(in_sizes.x) * y);
Expand All @@ -66,6 +54,6 @@ void main() {
}
}

imageStore(image_out, pos, out_texel);
imageStore(image_idx, pos, idx_texel);
imageStore(t_out, pos, out_texel);
imageStore(t_idx, pos, idx_texel);
}
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/max_pool2d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ max_pool2d:
parameter_names_with_default_values:
NDIM: 3
DTYPE: float
STORAGE: texture3d
generate_variant_forall:
DTYPE:
- VALUE: half
Expand Down
Loading