Remove exception fall back on checkpoint loading #9660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aea9736 with merge base 07266f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
added
ciflow/trunk
and removed
CLA Signed
mcr229
reviewed
Mar 26, 2025
| # Also, the checkpoint is loaded and dtype promoted to the transformer's dtype, which is | ||
| # by default initialized to fp32. This is fine because every other supported type | ||
| # losslessly converts to fp32, so we don't lose precision here. | ||
| if checkpoint: |
There was a problem hiding this comment.
yea i like this. If the user gives a checkpoint that doesn't work, we should fail, and not hide it under the rug and give them uninitialized model
mcr229
approved these changes
Mar 26, 2025
facebook-github-bot
added
the
CLA Signed
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
### Summary Remove the crutch of initializing with 0 weights when the checkpoint loading goes wrong (e.g. in most cases when the checkpoint keys don't match the parameters of the model). ### Test plan See if CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the crutch of initializing with 0 weights when the checkpoint loading goes wrong (e.g. in most cases when the checkpoint keys don't match the parameters of the model).
Test plan
See if CI passes