[Benchmark] add addmm example and test #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yf225
requested changes
Sep 4, 2025
benchmarks/run.py
Outdated
| {"B": 4, "T": 512, "v_range": "10,15"} | ||
| if os.environ.get("HELION_DEV_LOW_VRAM", "0") == "1" | ||
| else {} | ||
| ), |
There was a problem hiding this comment.
curious do we need these two changes?
There was a problem hiding this comment.
Sorry, it should be linter formatting change. Let me fix it.
examples/addmm.py
Outdated
| @@ -0,0 +1,83 @@ | |||
| """ | |||
There was a problem hiding this comment.
I believe we should be able to directly use the kernel in matmul.py which also does addmm (and avoid needing to create a new file)
There was a problem hiding this comment.
Thank you. I changed the addmm benchmark to reuse matmul Helion kernel example.
74 tasks
yf225
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Benchmark] add addmm example and test
For the Triton kernel benchmarking issue #234.