-
Notifications
You must be signed in to change notification settings - Fork 36
Add rms_norm backward kernels #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rms_norm backward kernels #597
Conversation
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
Summary: We add the backward pass for rms_norm kernel Differential Revision: D82359685
f9d50a2
to
73f1eee
Compare
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
Summary: We add the backward pass for rms_norm kernel Differential Revision: D82359685
73f1eee
to
8612505
Compare
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
Summary: We add the backward pass for rms_norm kernel Differential Revision: D82359685
8612505
to
52ee097
Compare
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
Summary: We add the backward pass for rms_norm kernel Differential Revision: D82359685
52ee097
to
c555c08
Compare
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mengluy0125 ! lgtm overall, and there are some linter error that needs fix. Also added an internal comment on the diff.
Summary: We add the backward pass for rms_norm kernel Differential Revision: D82359685
c555c08
to
b786e9d
Compare
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mengluy0125 !
Summary: We add the backward pass for rms_norm kernel
Differential Revision: D82359685