Skip to content

Conversation

mengluy0125
Copy link
Contributor

Summary: We add the backward pass for rms_norm kernel

Differential Revision: D82359685

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 15, 2025
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

mengluy0125 added a commit to mengluy0125/helion that referenced this pull request Sep 15, 2025
Summary:

We add the backward pass for rms_norm kernel

Differential Revision: D82359685
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

mengluy0125 added a commit to mengluy0125/helion that referenced this pull request Sep 15, 2025
Summary:

We add the backward pass for rms_norm kernel

Differential Revision: D82359685
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

mengluy0125 added a commit to mengluy0125/helion that referenced this pull request Sep 15, 2025
Summary:

We add the backward pass for rms_norm kernel

Differential Revision: D82359685
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

mengluy0125 added a commit to mengluy0125/helion that referenced this pull request Sep 15, 2025
Summary:

We add the backward pass for rms_norm kernel

Differential Revision: D82359685
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mengluy0125 ! lgtm overall, and there are some linter error that needs fix. Also added an internal comment on the diff.

Summary:

We add the backward pass for rms_norm kernel

Differential Revision: D82359685
@facebook-github-bot
Copy link

@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82359685.

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mengluy0125 !

@facebook-github-bot facebook-github-bot merged commit b744b29 into pytorch:main Sep 16, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants