Add hl.rand op with seed arg lowering to tl.rand #652
Merged
+213
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthickai
added a commit
that referenced
this pull request
Sep 22, 2025
stack-info: PR: #652, branch: karthickai/stack/2
karthickai
force-pushed
the
karthickai/stack/2
branch
from
04d0e9b to
300de6b
Compare
meta-cla
bot
added
the
CLA Signed
yf225
reviewed
Sep 22, 2025
karthickai
added a commit
that referenced
this pull request
Sep 22, 2025
stack-info: PR: #652, branch: karthickai/stack/2
karthickai
force-pushed
the
karthickai/stack/2
branch
from
300de6b to
d82cc97
Compare
karthickai
added a commit
that referenced
this pull request
Sep 22, 2025
stack-info: PR: #652, branch: karthickai/stack/2
karthickai
force-pushed
the
karthickai/stack/2
branch
from
d82cc97 to
0d507e3
Compare
yf225
requested changes
Sep 22, 2025
test/test_rng.py
Outdated
| def test_hl_rand_3d(self): | ||
| import helion | ||
|
|
||
| @helion.kernel(ref_mode=helion.RefMode.EAGER) |
There was a problem hiding this comment.
Maybe remove the ref_mode setting? The code as-is will explicitly test ref eager mode instead of normal Helion compile mode, but here I believe the intent is to test compile mode. (We have other harness to run tests in ref eager mode automatically so usually we don't need to worry about it.)
There was a problem hiding this comment.
thanks for the catch! I added that line for debugging to check the ref implementation and forgot to remove it. I’ve updated it now.
test/test_rng.py
Outdated
| self.assertTrue(torch.all(output < 1.0), "All values should be < 1") | ||
|
|
||
| def test_hl_rand_3d(self): | ||
| import helion |
There was a problem hiding this comment.
I've removed that line.
stack-info: PR: #652, branch: karthickai/stack/2
karthickai
force-pushed
the
karthickai/stack/2
branch
from
0d507e3 to
c112edb
Compare
jansel
reviewed
Sep 26, 2025
|
|
||
| numel = " * ".join(shape_str.strip("[]").split(",")) | ||
| seed_ast = state.ast_arg(1) | ||
| offs_expr = f"tl.arange(0, {numel}).reshape({shape_str})" |
There was a problem hiding this comment.
This is incorrect.
- Every tile will get the same RNG values.
- The RNG values will depend on the tile size due to the reshape
jansel
added a commit
that referenced
this pull request
Sep 26, 2025
jansel
added a commit
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add hl.rand op with seed arg lowering to tl.rand