Skip to content

Conversation

PaulZhang12
Copy link
Contributor

@PaulZhang12 PaulZhang12 commented Sep 30, 2025

Stacked PRs:


Faster Helion JSD

Benchmarking command: HELION_USE_DEFAULT_CONFIG=0 HELION_PRINT_OUTPUT_CODE=1 HELION_AUTOTUNE_ACCURACY_CHECK=1 HELION_AUTOTUNE_RANDOM_SEED=0 CUDA_VISIBLE_DEVICES=7 python benchmarks/run.py --op jsd --num-inputs 3 --metrics speedup 2>&1 | tee ~/test_helion.log

       (B, T, V)    liger_jsd-speedup    torch_compile_jsd-speedup    helion_jsd_tritonbench-speedup
----------------  -------------------  ---------------------------  --------------------------------
 (4, 2048, 4096)             3.07473                       8.75428                           8.20297
 (4, 2048, 8192)             3.33668                       9.41338                           9.06205
(4, 2048, 16384)             0.587061                      9.38754                           8.82071
         average             2.33282                       9.18507                           8.69524

PaulZhang12 added a commit that referenced this pull request Sep 30, 2025
stack-info: PR: #733, branch: PaulZhang12/stack/9
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 30, 2025
@yf225
Copy link
Contributor

yf225 commented Sep 30, 2025

The Triton misaligned address error / unspecified launch failure error can be repro'ed with this config: @helion.kernel(config=helion.Config(block_sizes=[4, 256], indexing='tensor_descriptor', num_stages=4, num_warps=4, pid_type='flat', range_flattens=[None, False], range_multi_buffers=[None, False], range_num_stages=[0, 4], range_unroll_factors=[0, 0], range_warp_specializes=[]), static_shapes=True)

@yf225
Copy link
Contributor

yf225 commented Oct 4, 2025

@PaulZhang12 #792 is merged and should unblock this PR. Thanks!

oulgen pushed a commit that referenced this pull request Oct 4, 2025
stack-info: PR: #733, branch: PaulZhang12/stack/9
@oulgen oulgen force-pushed the PaulZhang12/stack/9 branch from f9e5178 to a15d1a4 Compare October 4, 2025 07:08
PaulZhang12 added a commit that referenced this pull request Oct 6, 2025
stack-info: PR: #733, branch: PaulZhang12/stack/9
stack-info: PR: #733, branch: PaulZhang12/stack/9
@PaulZhang12 PaulZhang12 requested review from Sibylau, jansel and yf225 and removed request for Sibylau, jansel and yf225 October 6, 2025 17:09
Copy link
Contributor

@Sibylau Sibylau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PaulZhang12 PaulZhang12 requested review from jansel and yf225 and removed request for yf225 October 6, 2025 17:40
@PaulZhang12 PaulZhang12 merged commit 432c653 into main Oct 6, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants