Skip to content

Move upload benchmark results to a separate workflows #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

Move upload benchmark results to a separate workflows #758

merged 4 commits into from
Oct 2, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 1, 2025 •
edited
Loading

huydhn added 2 commits October 1, 2025 15:11
@huydhn
Move upload benchmark results to a separate workflows
6756120 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Use the right workflow
ced4c3a 
Signed-off-by: Huy Do <huydhn@gmail.com>
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 1, 2025
@huydhn huydhn mentioned this pull request Oct 1, 2025
Merged
@huydhn
Typo
9f17465 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn marked this pull request as ready for review October 1, 2025 23:07
huydhn added a commit to pytorch/test-infra that referenced this pull request Oct 2, 2025
@huydhn
Create upload_benchmark_results reusable workflow (#7269)
482f9b0 
This is needed to unblock pytorch/helion#732. By
unravelled the current upload_benchmark_results GHA, the new
`.github/workflows/upload_benchmark_results.yml` workflow needs 4
inputs:
1. The benchmark artifact itself, uploaded to GitHub via
`actions/upload-artifact`
2. The benchmark metadata including workflow ID, job ID, repo, and
branch name. This is collected by the new `gather-benchmark-metadata`
GHA
3. The runners info including GPU or CPU type. This is collected by the
new `gather-runners-info` GHA
4. The list of dependencies. This is collected by the new
`gather-dependencies` GHA

Two examples on how to use the new reusable workflow are at:
* `.github/workflows/test_upload_benchmark_results.yml`
* Helion pytorch/helion#758

---------

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Ready to land
9c56f3c 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Copy link
Contributor Author

huydhn commented Oct 2, 2025

So far, the b200 and mi325x test runs look good and I can see the benchmark results on https://hud.pytorch.org/benchmark/llms?startTime=Thu%2C%2025%20Sep%202025%2001%3A40%3A03%20GMT&stopTime=Thu%2C%2002%20Oct%202025%2001%3A40%3A03%20GMT&granularity=day&lBranch=use-upload-benchmark-results-workflow&lCommit=9f17465f6f26ed48d5d8116c6719a59ef95a7955&rBranch=use-upload-benchmark-results-workflow&rCommit=9f17465f6f26ed48d5d8116c6719a59ef95a7955&repoName=pytorch%2Fhelion&benchmarkName=Helion%20Benchmark&modelName=All%20Models&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=All%20Devices&archName=All%20Platforms

Let's land this

@huydhn huydhn merged commit 7b543c3 into main Oct 2, 2025
13 checks passed
@seemethere seemethere mentioned this pull request Oct 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huydhn @seemethere