Skip to content

Conversation

EikanWang
Copy link
Collaborator

As the title.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 2, 2025
@EikanWang
Copy link
Collaborator Author

I checked all failures. It was due to a newly added line of code to skip a few test cases on XPU - from helion._testing import skipIfXPU. The newly added line of code changes the line number information.

Should I update the expected file directly? @yf225

@oulgen
Copy link
Contributor

oulgen commented Oct 2, 2025

I checked all failures. It was due to a newly added line of code to skip a few test cases on XPU - from helion._testing import skipIfXPU. The newly added line of code changes the line number information.

Should I update the expected file directly? @yf225

Run tests with EXPECTTEST_ACCEPT=1 to automatically update expected files

@EikanWang EikanWang requested a review from yf225 October 2, 2025 17:50
@oulgen
Copy link
Contributor

oulgen commented Oct 2, 2025

you need to rebase one more time

@EikanWang EikanWang force-pushed the generalize-cuda-test-cases branch from c2cbb7c to d0b3ab6 Compare October 2, 2025 18:03
@oulgen
Copy link
Contributor

oulgen commented Oct 2, 2025

@EikanWang you're still having some line number disparity, please rebase to main and run

EXPECTTEST_ACCEPT=1 pytest test/test_type_propagation.py

@EikanWang
Copy link
Collaborator Author

Thanks. I will find a CUDA machine and do it.

@EikanWang EikanWang force-pushed the generalize-cuda-test-cases branch from bb1f0ee to 4ec76e6 Compare October 2, 2025 22:21
@EikanWang
Copy link
Collaborator Author

EikanWang commented Oct 2, 2025

@jansel, @oulgen, may I know the merge process for an approved PR? Can I merge it directly if the CI signal is green? Or is there any other process that I need to follow?

@oulgen oulgen merged commit 9fa7bbf into pytorch:main Oct 2, 2025
13 checks passed
@oulgen
Copy link
Contributor

oulgen commented Oct 2, 2025

@jansel, @oulgen, may I know the merge process for an approved PR? Can I merge it directly if the CI signal is green? Or is there any other process that I need to follow?

i merged for you. Did you have merge permissions?

@oulgen
Copy link
Contributor

oulgen commented Oct 2, 2025

@EikanWang is there an XPU machine we can use for the CI?

@EikanWang
Copy link
Collaborator Author

@oulgen , we are setting up the XPU machines and will enable XPU CI as long as these machines are ready.

@jansel
Copy link
Contributor

jansel commented Oct 2, 2025

@jansel, @oulgen, may I know the merge process for an approved PR? Can I merge it directly if the CI signal is green? Or is there any other process that I need to follow?

You can merge if CI is green and you have an approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants