Apply simplification to range indexing in order to reuse block size symbols #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yf225
force-pushed
the
int4_gemm_symbol_error
branch
from
9ec21d9 to
24a04ce
Compare
oulgen
approved these changes
Oct 4, 2025
yf225
force-pushed
the
int4_gemm_symbol_error
branch
6 times, most recently
from
017543b to
a8ac5c0
Compare
yf225
force-pushed
the
int4_gemm_symbol_error
branch
9 times, most recently
from
601ebd4 to
4ac6c7d
Compare
yf225
commented
Oct 7, 2025
| self.assertExpectedJournal(code) | ||
|
|
||
| expected = y_true[:, : y_pred.size(0)].sum() / y_pred.size(0) | ||
| expected = y_true[:, :].sum() / y_pred.size(0) |
There was a problem hiding this comment.
The original expected value is buggy - to match the intended kernel behavior, it should have been a sum on y_true[:, :] not y_true[:, : y_pred.size(0)].
yf225
changed the title
Merged
jansel
approved these changes
Oct 7, 2025
yf225
force-pushed
the
int4_gemm_symbol_error
branch
from
4ac6c7d to
893eee9
Compare
yf225
force-pushed
the
int4_gemm_symbol_error
branch
from
893eee9 to
7ecaeb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
A[tile_k.begin * 2 : tile_k.begin * 2 + tile_k.block_size * 2]toA[0:tile_k.block_size * 2], so that thetile_k.block_sizesymbol will be reused in the output shape to avoid downstream symbol mismatch errors.Fixes #753.