-
Notifications
You must be signed in to change notification settings - Fork 38
Improved log messages for autotuning #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Elaborate more on what's happening during autotuning so user can understands better. Set the expectation in the beginning that autotuning will take a while. For the progress bar, instead of using the rich backend of tqdm, we can use rich itself, which allows removing the warning message, "TqdmExperimentalWarning: rich is experimental/alpha", as well as customize the progress bar better (colors, remove some of the clutter with expected time, which is not accurate, and rounds/s speed). If cache hits so we don't need to run autotuning, let the user know and how the cache can be removed. Overall, autotuner log messages are cleaner and elaborate more on what's happening.
7713d2f
to
4585a6f
Compare
4c515ba
to
e4112a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice how the tqdm progress bar has some speed metrics to the right hand side, which is why i didnt use rich directly. Can you check whether it is possible to add something like that without tqdm?
@oulgen yes it can do something like this: But I thought the processing speed wasn't that meaningful to the user (although it looks cool :) ) and probably takes a bit of CPU time. I can put it back if you'd like. |
lets put it back in, looks cool :D |
@oulgen I hope this to your liking sir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
Elaborate more on what's happening during autotuning so user can understands better. Let the user know that autotuning will take a while.
For the progress bar, instead of using the rich backend of tqdm, we can use rich itself, which allows removing the warning message, "TqdmExperimentalWarning: rich is experimental/alpha", as well as customize the progress bar better (colors, remove some of the clutter).
If cache hits so we don't need to run autotuning, let the user know where the cache is and how it can be invalidated.
Previous messages (when cache misses)

New messages (when cache misses)

New messages (when cache hits)
