Skip to content

Conversation

choijon5
Copy link
Contributor

@choijon5 choijon5 commented Oct 6, 2025

Elaborate more on what's happening during autotuning so user can understands better. Let the user know that autotuning will take a while.

For the progress bar, instead of using the rich backend of tqdm, we can use rich itself, which allows removing the warning message, "TqdmExperimentalWarning: rich is experimental/alpha", as well as customize the progress bar better (colors, remove some of the clutter).

If cache hits so we don't need to run autotuning, let the user know where the cache is and how it can be invalidated.

Previous messages (when cache misses)
image

New messages (when cache misses)
image

New messages (when cache hits)
image

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 6, 2025
Elaborate more on what's happening during autotuning so user can understands better.
Set the expectation in the beginning that autotuning will take a while.
For the progress bar, instead of using the rich backend of tqdm, we can use
rich itself, which allows removing the warning message,
"TqdmExperimentalWarning: rich is experimental/alpha", as well as
customize the progress bar better (colors, remove some of the clutter
with expected time, which is not accurate, and rounds/s speed).
If cache hits so we don't need to run autotuning, let the user know and
how the cache can be removed.
Overall, autotuner log messages are cleaner and elaborate more on what's
happening.
@choijon5 choijon5 force-pushed the improved_logs_for_autotuning branch from 7713d2f to 4585a6f Compare October 6, 2025 03:01
@choijon5 choijon5 requested review from jansel and oulgen October 6, 2025 03:03
@choijon5 choijon5 force-pushed the improved_logs_for_autotuning branch from 4c515ba to e4112a0 Compare October 6, 2025 03:13
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice how the tqdm progress bar has some speed metrics to the right hand side, which is why i didnt use rich directly. Can you check whether it is possible to add something like that without tqdm?

@choijon5
Copy link
Contributor Author

choijon5 commented Oct 6, 2025

@oulgen yes it can do something like this:
image

But I thought the processing speed wasn't that meaningful to the user (although it looks cool :) ) and probably takes a bit of CPU time. I can put it back if you'd like.

@oulgen
Copy link
Contributor

oulgen commented Oct 6, 2025

@oulgen yes it can do something like this: image

But I thought the processing speed wasn't that meaningful to the user (although it looks cool :) ) and probably takes a bit of CPU time. I can put it back if you'd like.

lets put it back in, looks cool :D
maybe make them different color?

@choijon5
Copy link
Contributor Author

choijon5 commented Oct 7, 2025

@oulgen I hope this to your liking sir
image

@choijon5 choijon5 requested a review from oulgen October 7, 2025 03:11
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@oulgen oulgen merged commit 70c4120 into main Oct 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants