Skip to content

added tuple type to mixins.py #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2020
Merged

added tuple type to mixins.py #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c354a8e
added tuple type to mixins.py
thescripted Oct 5, 2020
28dcbd9
allow mypy to pass through base file
thescripted Oct 5, 2020
776542e
fixed linting issues
thescripted Oct 5, 2020
dfd9ae2
Merge branch 'master' into ignite.base_typing
vfdev-5 Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ignite/base/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

class Serializable:

_state_dict_all_req_keys = ()
_state_dict_one_of_opt_keys = ()
_state_dict_all_req_keys = () # type: tuple
_state_dict_one_of_opt_keys = () # type: tuple

def state_dict(self) -> OrderedDict:
pass
Expand Down
4 changes: 0 additions & 4 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ files = ignite
pretty = True
show_error_codes = True

[mypy-ignite.base.*]

ignore_errors = True

[mypy-ignite.contrib.*]

ignore_errors = True
Expand Down