Skip to content

fix ReduceOp typing issue #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix ReduceOp typing issue #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ignite/distributed/comp_models/native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ def spawn( # type: ignore[override]
def _do_all_reduce(self, tensor: torch.Tensor, op: str = "SUM") -> torch.Tensor:
if op not in self._reduce_op_map:
raise ValueError("Unsupported reduction operation: '{}'".format(op))
op = self._reduce_op_map[op]
dist.all_reduce(tensor, op)
reduce_op = self._reduce_op_map[op]
dist.all_reduce(tensor, reduce_op)
return tensor

def _do_all_gather(self, tensor: torch.Tensor) -> torch.Tensor:
Expand Down
2 changes: 1 addition & 1 deletion ignite/handlers/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import tempfile
import warnings
from abc import ABCMeta, abstractmethod
from collections import OrderedDict, namedtuple
from collections import OrderedDict
from tempfile import _TemporaryFileWrapper # type: ignore[attr-defined]
from typing import Any, Callable, Dict, List, Mapping, NamedTuple, Optional, Tuple, Union

Expand Down