Activate mypy for contrib.handlers #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gruebel thanks a lot for the PR ! Maybe, it would be more simple to split the PR into multiple ones (simplier reviewing) and either we can try to rework |
vfdev-5
reviewed
Dec 3, 2020
There was a problem hiding this comment.
@gruebel I reviewed all files except ignite/contrib/handlers/param_scheduler.py , so let's split this PR into 2: 1 = everything without ignite/contrib/handlers/param_scheduler.py and 2 = only ignite/contrib/handlers/param_scheduler.py
I left a comment to improve a bit tqdm handler. Otherwise, looks good to me.
|
Sure, no problem. I removed the changes on |
vfdev-5
reviewed
Dec 5, 2020
vfdev-5
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1406
Description:
That was brutal. Especially the
param_scheduler.pyis such a mess 😄 A lot of the time I had to guess and debug to find out what types are used/returned.Since the private class
torch.optim.lr_scheduler._LRSchedulerhas no types defined, I had to addtype: ignorequite often 😢