Skip to content

Conversation

trsvchn
Copy link
Collaborator

@trsvchn trsvchn commented Feb 19, 2021

Fixes #1649

Description:

I think the footer added here:

{% include "footer.html" %}

Moreover, "Built with Sphinx using a theme provided by Read the Docs." is hard coded in footer.html theme's template.

So, I think we can override footer.html with netlify badge.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 19, 2021

@trsvchn thanks for hacking it :) Looks good ! I wonder also if it could be difficult to set the badge on the same line as the copyright and "Built with Sphinx ..." ?

@trsvchn
Copy link
Collaborator Author

trsvchn commented Feb 19, 2021

This is the result of footer tweaking.

Screenshot from 2021-02-19 18-00-29

Maybe we can do this with pure css. But it doesn't look simple to me.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 19, 2021

Thanks a lot @trsvchn ! Looks great so far!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@vfdev-5 vfdev-5 merged commit 3d6ce4a into pytorch:master Feb 19, 2021
@trsvchn trsvchn mentioned this pull request Feb 19, 2021
3 tasks
@vfdev-5 vfdev-5 mentioned this pull request Mar 1, 2021
vfdev-5 pushed a commit that referenced this pull request Mar 1, 2021
* Enable footer for the docs

* Fix elements order

* Adjust deploy badge location

* Fix order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a footer on main docs site
2 participants