[BC-breaking] Move detach outside of loss function computation #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
changed the title
sdesrozis
approved these changes
Feb 23, 2021
|
@y0ast could you please send a follow-up PR that emulates your duq evaluator example, such that we verify this fix ? Thanks |
|
@vfdev-5 do you mean in the form of a test? Or something else |
|
@y0ast yes, exactly, a test which verifies that grads could still flow even with using |
vfdev-5
pushed a commit
that referenced
this pull request
Mar 1, 2021
Fixes #1674 Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674
This is a proposal solution to the issue linked above. I am not 100% sure of the implications of this change.
However if it is deemed acceptable, I would hope that maybe it can be part of a 0.4.4 bugfix release.