-
-
Notifications
You must be signed in to change notification settings - Fork 655
docs: rm type hints in ignite.contrib.handlers (2) #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: vfdev <vfdev.5@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on that issue @ydcjeff !
I left few comments
Co-authored-by: vfdev <vfdev.5@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! A nit to remove kwargs from concat scheduler and good to go, I think.
* docs: only show type hints in docstring * Apply suggestions from code review Co-authored-by: vfdev <vfdev.5@gmail.com> * fix(docs): correctly link to missing links * docs: rm type hints in docstring of ignite.contrib.handlers * docs: rm type hints in docstring of ignite.contrib.handlers * Apply suggestions from code review Co-authored-by: vfdev <vfdev.5@gmail.com> * review: apply suggestions * fix: no return in __init__ * fix: return None in no argument __init__ * remove kwargs in ConcatScheduler.simulate_values * fix: remove unused mypy ignore Co-authored-by: vfdev <vfdev.5@gmail.com>
Part of #1665
Fixes #1665
Description:
Check list: