Skip to content

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Feb 22, 2021

Part of #1665
Fixes #1665

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on that issue @ydcjeff !
I left few comments

@ydcjeff ydcjeff changed the title docs: rm type hints in docstring of ignite.contrib.handlers docs: rm type hints in ignite.contrib.handlers Feb 23, 2021
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! A nit to remove kwargs from concat scheduler and good to go, I think.

@ydcjeff ydcjeff changed the title docs: rm type hints in ignite.contrib.handlers docs: rm type hints in ignite.contrib.handlers (2) Feb 23, 2021
@vfdev-5 vfdev-5 merged commit 1bc5450 into pytorch:master Feb 23, 2021
@ydcjeff ydcjeff deleted the ignite.contrib.handlers branch February 23, 2021 13:35
vfdev-5 added a commit that referenced this pull request Mar 1, 2021
* docs: only show type hints in docstring

* Apply suggestions from code review

Co-authored-by: vfdev <vfdev.5@gmail.com>

* fix(docs): correctly link to missing links

* docs: rm type hints in docstring of ignite.contrib.handlers

* docs: rm type hints in docstring of ignite.contrib.handlers

* Apply suggestions from code review

Co-authored-by: vfdev <vfdev.5@gmail.com>

* review: apply suggestions

* fix: no return in __init__

* fix: return None in no argument __init__

* remove kwargs in ConcatScheduler.simulate_values

* fix: remove unused mypy ignore

Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use autodoc_typehints = "description" in conf.py
2 participants