Skip to content

Conversation

Moh-Yakoub
Copy link
Contributor

@Moh-Yakoub Moh-Yakoub commented Feb 22, 2021

Fixes #1680

Description:

Adding a Jaccard Index shortcut. https://en.wikipedia.org/wiki/Jaccard_index

It does the same computation as the IoU metric. Adding this shortcut as this is a more common name for the metric that IoU.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Moh-Yakoub !
I minor thing to fix in the docs
and update the docs: docs/source/metrics.rst

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 22, 2021

Thanks for the updates @Moh-Yakoub , few more things to update in the docs.

@Moh-Yakoub Moh-Yakoub force-pushed the add_jaccard_index_shortcut branch from 871988a to 8d9c8ea Compare February 22, 2021 23:23
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 23, 2021

@Moh-Yakoub I removed the type annotations from docstring as it is ongoing work now, see #1665

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vfdev-5 vfdev-5 merged commit e9b3d53 into pytorch:master Feb 23, 2021
@vfdev-5 vfdev-5 mentioned this pull request Feb 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Jaccard index for metrics
2 participants