Skip to content

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Feb 23, 2021

Part of #1665
Fixes #1665
https://deploy-preview-1685--pytorch-ignite-preview.netlify.app/engine.html

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff ydcjeff changed the title docs: rm type hints in ignite.engine docs: rm type hints in ignite.engine (3) Feb 23, 2021
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff !

@vfdev-5 vfdev-5 merged commit de4c7aa into pytorch:master Feb 23, 2021
@ydcjeff ydcjeff deleted the ignite.engine branch February 23, 2021 15:03
vfdev-5 pushed a commit that referenced this pull request Mar 1, 2021
* docs: rm type hints in ignite.engine

* fix: remove unneeded class attribute

* fix: autodoc_inherit_docstring=True in conf.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use autodoc_typehints = "description" in conf.py
2 participants