-
-
Notifications
You must be signed in to change notification settings - Fork 655
docs: rm type hints in ignite.metrics (4) #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ydcjeff I propose to insert another PR before this one with sphinx version update and all those conf.py flags. What do you think ? |
Sounds great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @ydcjeff
I let others to review this PR as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ydcjeff Looks good to me. Thank you, especially for adding missing docstring regarding arguments of methods.
* docs: rm type hints in ignite.metrics * fix: down sphinx=3.2.1, normalize * fix: down sphinx=3.2.1, normalize
Part of #1665
Fixes #1665
https://deploy-preview-1686--pytorch-ignite-preview.netlify.app/metrics.html
Description:
Check list: