Skip to content

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Feb 23, 2021

Part of #1665
Fixes #1665
https://deploy-preview-1687--pytorch-ignite-preview.netlify.app/distributed.html

Description:

  • remove type hints in ignite.distributed
  • add missing doc string

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff ydcjeff marked this pull request as draft February 23, 2021 10:01
@ydcjeff ydcjeff changed the title docs: rm type hints in ignite.distributed docs: rm type hints in ignite.distributed (5) Feb 23, 2021
@ydcjeff ydcjeff marked this pull request as ready for review February 23, 2021 15:31
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ydcjeff !
I think we can merge this one before metrics, right ?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Feb 24, 2021

LGTM! Thanks @ydcjeff !
I think we can merge this one before metrics, right ?

Yes, both can be merge independently now.

@vfdev-5 vfdev-5 merged commit 314b87f into pytorch:master Feb 24, 2021
@ydcjeff ydcjeff deleted the ignite.distributed branch February 24, 2021 12:59
vfdev-5 pushed a commit that referenced this pull request Mar 1, 2021
* docs: rm type hints in ignite.metrics

* docs: rm type hints in ignite.distributed

* Revert "docs: rm type hints in ignite.metrics"

This reverts commit a94b50e.

* Update conf.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use autodoc_typehints = "description" in conf.py
2 participants