Skip to content

Conversation

goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Sep 4, 2025

Add typing and style checks as separate workflows

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 15:48
@github-actions github-actions bot added module: handlers Core Handlers module ci CI labels Sep 4, 2025
Copilot

This comment was marked as outdated.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 4, 2025

@goanpeca should we also remove mypy check step from unit-tests.yml:

- name: Run Mypy
# https://github.com/pytorch/ignite/pull/2780
#
if: ${{ matrix.os == 'ubuntu-latest' }}
run: |
mypy

@goanpeca goanpeca marked this pull request as draft September 4, 2025 22:40
@goanpeca
Copy link
Collaborator Author

goanpeca commented Sep 4, 2025

should we also remove mypy check step from unit-tests.yml:

Yes I will remove that!

@goanpeca goanpeca force-pushed the enh/checks branch 2 times, most recently from 00318bd to f968747 Compare September 5, 2025 13:43
@goanpeca goanpeca marked this pull request as ready for review September 5, 2025 13:44
@goanpeca goanpeca requested a review from Copilot September 5, 2025 13:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request separates typing and style checks into dedicated GitHub Actions workflows, moving them out of the main unit test workflow to improve CI organization and performance.

  • Removes code formatting and MyPy checks from the unit test workflow
  • Creates a new dedicated typing checks workflow that runs MyPy on multiple Python versions
  • Replaces the automatic code formatting workflow with a code style checks workflow that validates formatting without auto-fixing

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/unit-tests.yml Removes code formatting and MyPy type checking steps
.github/workflows/typing-checks.yml New workflow for running MyPy type checking on Python 3.9 and 3.13
.github/workflows/code-style.yml Removes the old automatic code formatting workflow
.github/workflows/code-style-checks.yml New workflow for validating code style without auto-fixing
ignite/handlers/clearml_logger.py Adds type annotations and type ignore comments for MyPy compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gonzalo!

@vfdev-5 vfdev-5 merged commit f41b1e3 into pytorch:master Sep 5, 2025
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants