-
-
Notifications
You must be signed in to change notification settings - Fork 655
Add typing and style checks as separate workflows #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@goanpeca should we also remove mypy check step from unit-tests.yml: ignite/.github/workflows/unit-tests.yml Lines 100 to 105 in 400973d
|
Yes I will remove that! |
00318bd
to
f968747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request separates typing and style checks into dedicated GitHub Actions workflows, moving them out of the main unit test workflow to improve CI organization and performance.
- Removes code formatting and MyPy checks from the unit test workflow
- Creates a new dedicated typing checks workflow that runs MyPy on multiple Python versions
- Replaces the automatic code formatting workflow with a code style checks workflow that validates formatting without auto-fixing
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.github/workflows/unit-tests.yml | Removes code formatting and MyPy type checking steps |
.github/workflows/typing-checks.yml | New workflow for running MyPy type checking on Python 3.9 and 3.13 |
.github/workflows/code-style.yml | Removes the old automatic code formatting workflow |
.github/workflows/code-style-checks.yml | New workflow for validating code style without auto-fixing |
ignite/handlers/clearml_logger.py | Adds type annotations and type ignore comments for MyPy compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gonzalo!
Add typing and style checks as separate workflows