Allow torch._C to be recognized a module in torch.package in pytorch/multipy #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37630606 |
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 88.99% 88.94% -0.05%
==========================================
Files 65 65
Lines 3842 3862 +20
==========================================
+ Hits 3419 3435 +16
- Misses 423 427 +4
Continue to review full report at Codecov.
|
PaliC
added a commit
to PaliC/multipy
that referenced
this pull request
Jul 5, 2022
…multipy (pytorch#91) Summary: Pull Request resolved: pytorch#91 This pr addresses pytorch#82 and pytorch#44. A C extension module behaves a bit differently than a normal python package as it does not contain a `__path__` attribute. However, these modules still have information about their submodules. This PR also checks if a module is a C extension module and checks if the module we are looking for is in it's children. For example, if we are importing `torch._C._nn` we check if the parent `torch._C` is a C extension module if necessary, and then check if `torch._C._nn` is a proper child of `torch._C`. The corresponding PR in torch.package is pytorch/pytorch#80917 Differential Revision: D37630606 fbshipit-source-id: 65e549b66550d676a0e766a5f0c38b417f038a20
|
This pull request was exported from Phabricator. Differential Revision: D37630606 |
PaliC
added a commit
to PaliC/multipy
that referenced
this pull request
Jul 6, 2022
…multipy (pytorch#91) Summary: Pull Request resolved: pytorch#91 This pr addresses pytorch#82 and pytorch#44. A C extension module behaves a bit differently than a normal python package as it does not contain a `__path__` attribute. However, these modules still have information about their submodules. This PR also checks if a module is a C extension module and checks if the module we are looking for is in it's children. For example, if we are importing `torch._C._nn` we check if the parent `torch._C` is a C extension module if necessary, and then check if `torch._C._nn` is a proper child of `torch._C`. The corresponding PR in torch.package is pytorch/pytorch#80917 Differential Revision: D37630606 fbshipit-source-id: f18991665618291664a0b3b34c95f5dbb91247af
|
This pull request was exported from Phabricator. Differential Revision: D37630606 |
PaliC
added a commit
to PaliC/multipy
that referenced
this pull request
Jul 11, 2022
…multipy (pytorch#91) Summary: Pull Request resolved: pytorch#91 This pr addresses pytorch#82 and pytorch#44. A C extension module behaves a bit differently than a normal python package as it does not contain a `__path__` attribute. However, these modules still have information about their submodules. This PR also checks if a module is a C extension module and checks if the module we are looking for is in it's children. For example, if we are importing `torch._C._nn` we check if the parent `torch._C` is a C extension module if necessary, and then check if `torch._C._nn` is a proper child of `torch._C`. The corresponding PR in torch.package is pytorch/pytorch#80917 Reviewed By: d4l3k Differential Revision: D37630606 fbshipit-source-id: 19e6bb808b893aaab39790929e130eb0bbd62d91
|
This pull request was exported from Phabricator. Differential Revision: D37630606 |
…multipy (pytorch#91) Summary: Pull Request resolved: pytorch#91 This pr addresses pytorch#82 and pytorch#44. A C extension module behaves a bit differently than a normal python package as it does not contain a `__path__` attribute. However, these modules still have information about their submodules. This PR also checks if a module is a C extension module and checks if the module we are looking for is in it's children. For example, if we are importing `torch._C._nn` we check if the parent `torch._C` is a C extension module if necessary, and then check if `torch._C._nn` is a proper child of `torch._C`. The corresponding PR in torch.package is pytorch/pytorch#80917 Reviewed By: d4l3k Differential Revision: D37630606 fbshipit-source-id: ee562573ea4c0bbc43facc5ae9a0fc4ad8f29cd6
|
This pull request was exported from Phabricator. Differential Revision: D37630606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pr addresses #82 and #44.
A C extension module behaves a bit differently than a normal python package as it does not contain a
__path__attribute. However, these modules still have information about their submodules. This PR also checks if a module is a C extension module and checks if the module we are looking for is in it's children.For example, if we are importing
torch._C._nnwe check if the parenttorch._Cis a C extension module if necessary, and then check iftorch._C._nnis a proper child oftorch._C.The corresponding PR in torch.package is pytorch/pytorch#80917
Differential Revision: D37630606